-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix Java UDAF OOM in spill or sorted streaming agg #48618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdpain
force-pushed
the
fix_udf_spill_case
branch
from
July 19, 2024 07:47
b3d662f
to
3613a87
Compare
stdpain
force-pushed
the
fix_udf_spill_case
branch
2 times, most recently
from
July 19, 2024 11:34
16be96b
to
0ae3d8e
Compare
In past implementations, Function States would not be released. For sorted streaming agg or spill aggregates, they will not be released even if destroy is called. This PR adds a remove state interface to Function States. After calling destroy, it will call function states-> remove. Signed-off-by: stdpain <[email protected]>
stdpain
force-pushed
the
fix_udf_spill_case
branch
from
July 20, 2024 01:56
0ae3d8e
to
be7d803
Compare
Quality Gate passedIssues Measures |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 58 / 65 (89.23%) file detail
|
Seaven
approved these changes
Jul 22, 2024
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
@Mergifyio backport branch-3.1 |
@Mergifyio backport branch-3.0 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
Signed-off-by: stdpain <[email protected]> (cherry picked from commit 36b3aae)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
Signed-off-by: stdpain <[email protected]> (cherry picked from commit 36b3aae)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
Signed-off-by: stdpain <[email protected]> (cherry picked from commit 36b3aae)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
Signed-off-by: stdpain <[email protected]> (cherry picked from commit 36b3aae) # Conflicts: # be/src/exprs/function_context.cpp
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 22, 2024
…48618) (#48671) Co-authored-by: stdpain <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 22, 2024
…48618) (#48670) Co-authored-by: stdpain <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 24, 2024
…48618) (#48669) Co-authored-by: stdpain <[email protected]>
dujijun007
pushed a commit
to dujijun007/starrocks
that referenced
this pull request
Jul 29, 2024
…s#48618) Signed-off-by: stdpain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
In past implementations, Function States would not be released.
For sorted streaming agg or spill aggregates, they will not be released even if destroy is called.
What I'm doing:
This PR adds a remove state interface to Function States.
After calling destroy, it will call function states-> remove.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: